search

atlassian-labs / compiled

A familiar and performant compile time CSS-in-JS library for React.
https://compiledcssinjs.com
Apache License 2.0
1.98k stars 68 forks source link

Fix CSS variables casing #1663

Closed mitchgavan closed 4 months ago

mitchgavan commented 4 months ago

Fixes the parsing of custom properties (CSS variables) names in object syntax. The casing is now preserved instead of being converted to kebab case.

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: b862caefc31caae1b15393d5113e0aecadb85007

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages | Name | Type | | ------------------------------------ | ----- | | @compiled/babel-plugin | Patch | | @compiled/babel-plugin-strip-runtime | Patch | | @compiled/parcel-transformer | Patch | | @compiled/parcel-optimizer | Patch | | @compiled/webpack-loader | Patch | | @compiled/eslint-plugin | Patch | | @compiled/codemods | Patch | | @compiled/utils | Patch | | @compiled/jest | Patch | | @compiled/css | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

itsdouges commented 4 months ago

Can you add a patch changeset for all bundler packages as well please so they immediately get the bug fix? 🙏 (will ensure their dependency of babel is brought forward).

dddlr commented 4 months ago

thank you for the PR @mitchgavan :heart: LGTM once extra tests are added (douges' comments)

mitchgavan commented 4 months ago

Thanks folks, I've added the tests and changesets for the other packages.