Closed kylorhall-atlassian closed 1 week ago
Latest commit: 035de35ea13d48a0c79e3177022cef21e14a6752
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Name | Link |
---|---|
Latest commit | 035de35ea13d48a0c79e3177022cef21e14a6752 |
Latest deploy log | https://app.netlify.com/sites/compiled-css-in-js/deploys/6711cbb670de5c000838e143 |
Deploy Preview | https://deploy-preview-1724--compiled-css-in-js.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
What is this change?
Following https://github.com/atlassian-labs/compiled/pull/1717, throws an error when Parcel attempts to transform or Webpack's
CompiledExtractPlugin
is initialized with bothextract: true
andclassHashPrefix
being defined.Why are we making this change?
To avoid unsupported usage and bundle size creep as adding 5 bytes to every class is not something we want to generally promote and instead
classHashPrefix
is only desired as a temporary workaround to avoid conflicts in scenarios where non-extraction is used.How are we making this change?
Into the Parcel Transformer and Webpack Loader, the entrypoints where this configuration bleeds in. Technically this wasn't documented properly for
@compiled/webpack-loader
, so I adjusted it briefly, but kept thethrow new Error
in place to avoid this (as it would still be passed through, I'd gather).PR checklist
website/
— Modified briefly, but I'm not sure it's worth documenting in full (this already isn't documented in full).