TypeScript@3 peer dependency?

atlassian-labs / react-resource-router

Configuration driven routing solution for React SPAs that manages route matching, data fetching and progressive rendering

https://atlassian-labs.github.io/react-resource-router

Apache License 2.0

198 stars 28 forks source link

TypeScript@3 peer dependency? #114

Closed marionebl closed 2 years ago

marionebl commented 2 years ago

Receiving a peer dependency warning for react-resource-router

➤ YN0060: │ @atlassian/canvas@workspace:. provides typescript (p87734) with version 4.5.5, which doesn't satisfy what react-resource-router requests

I don't see why it would depend on an explicit TypeScript major, could the peer dependency be removed or widened?

albertogasparin commented 2 years ago

That is a very good point. To be honest dunno why TS and Tslib are marked as dependencies. We publish transpiled bundles with type defs, so they should not be required at all. Do you feel like raising PR to address that?

marionebl commented 2 years ago

https://github.com/atlassian-labs/react-resource-router/pull/117