search

atlassian-labs / react-resource-router

Configuration driven routing solution for React SPAs that manages route matching, data fetching and progressive rendering
https://atlassian-labs.github.io/react-resource-router
Apache License 2.0
202 stars 28 forks source link

resolving peer dependency warnings for react 17 #158

Open nikitr opened 2 years ago

nikitr commented 2 years ago

can we update the react dependencies in the package.json to remove these warnings?

warning " > react-resource-router@0.20.0" has incorrect peer dependency "react@^16.8.0". warning " > react-resource-router@0.20.0" has incorrect peer dependency "react-dom@^16.8.0".

for context, our project is on react 17. would we be able to add

"peerDependencies": {
    "react": "^16.8 || ^17.0",
    "react-dom": "^16.8 || ^17.0",
  },
theKashey commented 2 years ago

Let's include 18 as well. Not sure if React 17 is really used anywhere around - it was quite a temporal version.

nikitr commented 2 years ago

ok thanks @theKashey what will the timeline look like on updating this peer dependency?