Add compatibility for goBack and goForward with history@5

atlassian-labs / react-resource-router

Configuration driven routing solution for React SPAs that manages route matching, data fetching and progressive rendering

https://atlassian-labs.github.io/react-resource-router

Apache License 2.0

198 stars 28 forks source link

Add compatibility for goBack and goForward with history@5 #163

Closed danskyr closed 2 years ago

danskyr commented 2 years ago

In history@5 the goForward and goBack functions were renamed to forward and back. This means that react-resource-router will currently fail on these actions when used with history@5.

This PR fixes that and adds compatibility for these two actions with both history@4 and history@5.

atlassian-cla-bot[bot] commented 2 years ago

Thank you for your submission! Like many open source projects, we ask that you sign our CLA (Contributor License Agreement) before we can accept your contribution. If your email is listed below, please ensure that you sign the CLA with the same email address.
The following users still need to sign our CLA:
❌dreissenberger

_{Already signed the CLA? To re-check, try refreshing the page.}

gorakong commented 2 years ago

hey @liamqma and @albertogasparin, feel free to disregard the CLA check and merge the PR (if it's ready) since we've verified that these commits all come from an Atlassian 🙂.