Closed yamadapc closed 1 year ago
@yamadapc could you also update the docs for these actions? https://github.com/atlassian-labs/react-resource-router/blob/master/docs/api/components.md#routeractions
Should we update other types too?
For example, PublicRouterActions
https://github.com/atlassian-labs/react-resource-router/blob/master/src/controllers/router-store/types.ts#L107
Should we update other types too?
Didn't I update them?
ohh, sorry, I missed it. Can you update the Flow type too? https://github.com/atlassian-labs/react-resource-router/blob/master/src/types.js.flow#L218
Thanks Pedro. Can you rebase and add one test for push and one for replace? https://github.com/yamadapc/react-resource-router/blob/6e2a723dc8be31c3de7200563ed031e72ab9ba54/src/__tests__/unit/common/utils/history/test.ts#L91
Thanks @yamadapc !
Currently router store push/replace requires a string in the types, but they will work with location objects. This commit modifies their types as well as one history implementation to accept a location object.