Rtl upgrade - Githubissues

atlassian-labs / react-resource-router

Configuration driven routing solution for React SPAs that manages route matching, data fetching and progressive rendering

Apache License 2.0

198 stars 28 forks source link

Closed AlexanderKaran closed 10 months ago

AlexanderKaran commented 10 months ago

Upgraded all the tests from enzyme to react testing library to make upgrading to React 18 easier
Updated every test to RTL
Moved towards more testing patterns supported by RTL

SpanishPear commented 10 months ago

Looks good! I'll ping someone else to approve but ✅ from me (some nits, but they are nice to haves, not blocking)

AlexanderKaran commented 10 months ago

Looks good! I'll ping someone else to approve but ✅ from me (some nits, but they are nice to haves, not blocking)

Thanks for the review will fix up the comments you mentioned today