search

atlassian / bazel-tools

Reusable bits for Bazel
Apache License 2.0
113 stars 36 forks source link

Multirun per command env and args #42

Closed Globegitter closed 5 years ago

Globegitter commented 6 years ago

This is in some ways a follow-up PR to #41, in the sense that we actually realised we needed to be able to set env vars for each individual command (see https://github.com/bazelbuild/rules_k8s/issues/232) and then I thought we might as well allow args for each command to be set individually as it does not always work so well to pass the same args to all commands. Let me know what you think.

ash2k commented 5 years ago

I think it might be much less messy to model each runnable binary as a separate rule that exposes a provider, consumable by the multirun rule. Then each of those rules can be configured individually without messy string parsing (use dict vs parsing a string). WDYT?

ash2k commented 5 years ago

I couldn't make the provider idea work the way I envisioned, but I did something else instead. See https://github.com/atlassian/bazel-tools/pull/45 and let me know what you think.

ash2k commented 5 years ago

I've merged a different implementation, closing.