atlassian / bazel-tools

Reusable bits for Bazel
Apache License 2.0
113 stars 36 forks source link

Add Masterminds/sprig go template library #77

Closed pawelchcki closed 4 years ago

pawelchcki commented 4 years ago

Hi,

this PR adds https://github.com/Masterminds/sprig Go template functions library thats also used in Helm project extensively.

This library adds tons of very useful functions that make writing go templates a bit more interesting.

When creating the PR, I noticed it pulls in tons of dependencies. So I'd understand if this is too much for you :)

BTW I've already signed the CLA

ash2k commented 4 years ago

Thanks for the contribution! I don't mind merging it if you or someone else actually needs this functionality. Will it be used?

If yes, could you also update the docs for this rule, perhaps give a usage example or a link to examples. Whatever makes sense.

ash2k commented 4 years ago

@pawelchcki If you still want this merged, rebase and reopen the PR please as it's got a conflict now.