search

atlassian / cz-lerna-changelog

A commitizen adapter for the angular preset of https://github.com/conventional-changelog/conventional-changelog
110 stars 39 forks source link

Broken with Lerna@3.0 RC #16

Open ssilve1989 opened 6 years ago

ssilve1989 commented 6 years ago

When trying to use this with lerna@3.0.0-rc.0 it results in the following:

yarn run v1.9.2
$ git-cz
Cannot find module 'lerna/lib/Repository'
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
dorsharon commented 6 years ago

Also breaking for me. Please fix this

fabienheureux commented 6 years ago

I have a workaround for this issue: I removed commitizen from dependencies, and run it through a npm script "commit": "npx git-cz" It will work with npm versions that support npx, and this is clearly an issue that could be solved otherwise, but I personally did not have the time yet to dig this issue.

I found this workaround by mistake...I do not have a clue yet why it is breaking, hope it can help your case.

abusada commented 6 years ago

i made PR that fixes this, but i don't know if this repo is still maintained or not, we use it in our projects and we need it to support lerna 3

lukebatchelor commented 6 years ago

Hiya, wow, thanks for the contribution.

I'll try to get to it today and release a new major version.

daern91 commented 6 years ago

Amazing, thanks @abusada. This works great!

ibraelillo commented 4 years ago

Hi, I'm still facing this issue on my project!! This pr is from 2018, can you just publish it, please?

lukebatchelor commented 4 years ago

The PR in this issue was merged already and released in 2.0.0

https://github.com/atlassian/cz-lerna-changelog/pull/17#issuecomment-423435556