search

atlassian / cz-lerna-changelog

A commitizen adapter for the angular preset of https://github.com/conventional-changelog/conventional-changelog
110 stars 39 forks source link

Fix affected package detection on WIndows #20

Closed FinestV closed 4 years ago

FinestV commented 5 years ago

Currently affected packages are not detected on Windows due to git diff using forwardslash and npm path using backslash.

This normalizes the git diff paths before comparing them with the package paths

RubenVermeulen commented 4 years ago

Hi @lukebatchelor Is there a possibility this gets merged?

lukebatchelor commented 4 years ago

Hi @RubenVermeulen ,

Should be able to yup. I'm on leave without my work laptop ATM, but I'll set a reminder to do it next week.

Please feel free to ping me if I forget!

RubenVermeulen commented 4 years ago

Thanks @lukebatchelor!

RubenVermeulen commented 4 years ago

Hi @lukebatchelor

A friendly ping so you don't forget ;).

lukebatchelor commented 4 years ago

Agh, apologies @RubenVermeulen , I've gone to publish it but someone's refactored some last pass accounts and I don't have the login for it any more! Waiting on the team to get back to me, should be sorted tomorrow though.

lukebatchelor commented 4 years ago

Released in 2.0.3 👍