search

atlassian / data-center-helm-charts

Helm charts for Atlassian's Data Center products
https://atlassian.github.io/data-center-helm-charts/
Apache License 2.0
155 stars 132 forks source link

[Suggestion] - Allow the option to add annotations for Standalone synchrony service #398

Closed athira-1142 closed 1 year ago

athira-1142 commented 2 years ago

Suggestion

We have to add annotations on the services to enable session affinity and create a health check (backend configuration). At present, we can add annotations through values.yaml only on confluence service. For standalone synchrony service, we have to add annotations after the application is deployed.

It would be great if there is an option to add annotations on Synchrony service in values.yaml as we can manage everything through Helm.

Product

Confluence

Code of Conduct

errcode1202 commented 2 years ago

Hi @athira-1142,

Thankyou for the suggestion. For context, and so we can better understand what you need, would you mind creating a PR with the proposed changes. We can use that then as a talking point as a potential addition to main.

DarthKoax commented 2 years ago

This is a feature that we have discovered would be very helpful for us. We have run into the issue also with our build where Synchrony's health check and stickiness are configured incorrectly due to inheriting from our confluence ingress annotations.

This is recommended by Atlassian to have stickiness on for confluence and off for synchrony, along with health check pointing to /status for confluence and /sychrony/heartbeat for synchrony. https://confluence.atlassian.com/confkb/how-to-configure-amazon-web-service-application-load-balancer-with-confluence-859515417.html

If athira-1142 has not already started a PR, we may look into doing so.

altcourt commented 2 years ago

+1 for helpfulness for our build.