atlassian / data-center-helm-charts

Helm charts for Atlassian's Data Center products
https://atlassian.github.io/data-center-helm-charts/
Apache License 2.0
154 stars 132 forks source link

[Suggestion] - Add variables for application tunnels to values.yaml #659

Open BryanGuffeySonos opened 1 year ago

BryanGuffeySonos commented 1 year ago

Suggestion

Many consumers of the DC helm charts will need to connect to Atlassian Cloud application tunnels because they are running one application in Cloud and one on-prem using DC.

In order to successfully deploy application tunnels, the server.xml file needs to be modified with a new HTTP connector and a new JVM argument needs to be added, specifying an upstream port. See here: https://support.atlassian.com/organization-administration/docs/configure-required-connections-and-upstream-ports/

Additionally, one can restrict all traffic to localhost with additional modifications to server.xml, see here: https://support.atlassian.com/organization-administration/docs/configure-required-connections-and-upstream-ports/#Optional--Restrict-access-to-the-HTTP-connector-to-localhost

Finally, HTTPS redirection must be removed from the web.xml file, see here: https://support.atlassian.com/organization-administration/docs/configure-required-connections-and-upstream-ports/#Remove-HTTPS-redirection-from-the-web.xml-file

This seems like an excellent place to add some variables such as APPLICATION_TUNNEL_NEEDED, APPLICATION_TUNNEL_CONNECTOR_PORT, andRESTRICT_APPLICATION_TUNNEL_TO_LOCALHOST` which could then be used to generate the appropriate connector in server.xml, adjust the Engine if necessary, and add the flag to the JVM arguments, along with removing HTTPS redirection from web.xml, all from within the helm chart.

Product

Jira

Code of Conduct

bianchi2 commented 1 year ago

@BryanGuffeySonos indeed, there have been a few cases involving app tunnels. We'll definitely take a look at it, thanks for raising it!