search

atlassian / escalator

Escalator is a batch or job optimized horizontal autoscaler for Kubernetes
Apache License 2.0
663 stars 59 forks source link

Fixes scaling up problem #108

Closed leogdiniz closed 6 years ago

leogdiniz commented 6 years ago

Fixes #107

leogdiniz commented 6 years ago

Unfortunately, I have no idea why the job with go:master failed. With go 1.10.x It didn't fail. It's my first time doing something with Go so there is a chance that I did something wrong. Some help would be appreciated. =)

https://travis-ci.org/atlassian/escalator/builds/392085696

awprice commented 6 years ago

Thanks for opening this PR @leogdiniz! Could you please sign the CLA in the Contributing section of the readme? https://github.com/atlassian/escalator#contributors

leogdiniz commented 6 years ago

Hi @awprice. I've signed it already. On my docusign panel it's saying that it was already received by contributions@atlassian.com Could you check it, please?

awprice commented 6 years ago

@leogdiniz Awesome, I'm currently waiting on the team that manages contributions@atlassian.com to confirm with me that they have your signature. I'm also fixing the broken test in #106.

awprice commented 6 years ago

@leogdiniz I've updated the tests so it isn't failing now. I'm going to test this over the weekend and will get back to you if there are any changes to be made.

awprice commented 6 years ago

Awesome work on this @leogdiniz! 🎉🎉🎉

I've tested this in my cluster and it works perfectly. I can also replicate the bug you have described on the current version of Escalator.

Thanks for the contribution!

leogdiniz commented 6 years ago

Great news! This project is awesome. I'm looking forward to contributing more to it. I'll just improve my Go skills a little bit more first =)

Cheers