search

atlassian / escalator

Escalator is a batch or job optimized horizontal autoscaler for Kubernetes
Apache License 2.0
663 stars 59 forks source link

ASG minSize #143

Closed skydiator closed 5 years ago

skydiator commented 5 years ago

Hi,

Is there a reason why ASG minSize cannot be 0?

We have a use case of having ASGs with 0 node and scale up only when a job scheduled to that specific ASG. This help us reduce the cost of using high performance instances, so we pay only when needed.

If no objection, I can send in a PR with our changes.

Thanks

skydiator commented 5 years ago

@ShmayaFrankel , thanks for your reply. I know it doesn't but I want to know the reason behind it. I've modified Escalator to support ASG with 0 size. If this violates the implementation design then I don't bother sending in the MR. Thanks.

Jacobious52 commented 5 years ago

Hi @skydiator, glad to hear that you've been using Escalator!

Scaling down the ASG to a size of 0 is a planned feature for our use case as well. We are currently looking into it, and definitely welcome your pull request to scale down to an ASG of 0.

skydiator commented 5 years ago

Escalator is awesome! ATM, I'm doing more testing with the changes. So far so good, will send in the PR as soon as I've done my testings.

Jacobious52 commented 5 years ago

Hi @skydiator, just wondering if you have any update on the PR for this? If you have any questions or problems, feel free to ask here and we'll try help best we can.

skydiator commented 5 years ago

@Jacobious52 , PR-148 created for this.

Jacobious52 commented 5 years ago

Completed in #155