search

atlassian / escalator

Escalator is a batch or job optimized horizontal autoscaler for Kubernetes
Apache License 2.0
662 stars 59 forks source link

Ensure min_nodes and max_nodes are up to date with the cloud provider. #144

Closed skydiator closed 5 years ago

skydiator commented 5 years ago

During our testing, there's possibility that the min_nodes / max_nodes value can be updated via the AWS console or through API. This will help to ensure the RunOnce loop keep the min_nodes and max_nodes up to date.

skydiator commented 5 years ago

Sounds good. Grab me anytime if there's anything needs to work on.

Jacobious52 commented 5 years ago

I've tested the changes and all seems to be well. Of note, edge case testing included changing the minimum ASG size to a conflicting value while escalator was scaling up. Escalator behaved correctly by noting the current node count was less than the minimum and resolved to normal once the scale operation was complete.

Approved and merge/release shortly.