atlassian / escalator

Escalator is a batch or job optimized horizontal autoscaler for Kubernetes
Apache License 2.0
662 stars 59 forks source link

Need aws-go-sdk version updated to support iam:AssumeRoleWithWebIdentity at EKS #179

Closed hippothewild closed 4 years ago

hippothewild commented 4 years ago

Hi, I've been using Escalator so far for scaling k8s clusters with Spark batch jobs running inside. Thanks for building an awesome product!

I'm currently running Kubernetes cluster with Kops+Kiam which do not have any issue about assuming IAM role for Escalator pod, but when I try to run Escalator on EKS-managed cluster, it can't assume IAM role given by service account.

The root cause is that older version of AWS SDK does not support iam:AssumeRoleWithWebIdentity with OIDC provider. it seems resolvable when we update AWS SDK to the latest version - 1.23.13 is the minimum verison required.

It will be greatly appreciated if the new version with updated SDK is released. Thank you so much!

awprice commented 4 years ago

Thanks for raising this issue @hippothewild! This is perfectly doable.

hippothewild commented 4 years ago

Just opened a PR to handle this issue.