search

atlassian / extract-react-types

One stop shop for documenting your react components.
https://atlassian.github.io/extract-react-types/
MIT License
179 stars 28 forks source link

Add CI workflow #190

Closed declan-warn closed 3 years ago

declan-warn commented 3 years ago

Github action to replace Travis CI

changeset-bot[bot] commented 3 years ago

⚠️ No Changeset found

Latest commit: 3bb1f6a706317bf981d8655e0181f573065690eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

declan-warn commented 3 years ago

@danieldelcore it seems to be working now :)

Interesting it looks like the Travis pipeline wasn't catching linting errors? 🤔

Also I think you will need to make this new workflow a required one. It isn't preventing merges.

danieldelcore commented 3 years ago

Here's a PR for the lint errors breaking our beautiful new Action

https://github.com/atlassian/extract-react-types/pull/191

declan-warn commented 3 years ago

@danieldelcore seems like there was one more linting error that yarn lint:fix wasn't catching. I made a PR to fix it here and can confirm that's the last of them :) https://github.com/atlassian/extract-react-types/pull/193

danieldelcore commented 3 years ago

Great work on this one mate! Let's merge it!