search

atlassian / github-for-jira

Connect your code with your project management in Jira
https://github.atlassian.com
MIT License
620 stars 187 forks source link

Feature request: Create JIRA issue from PR Review #465

Open sfc-gh-sgiesecke opened 3 years ago

sfc-gh-sgiesecke commented 3 years ago

Just like it's possible to create a GitHub issue from a PR Review Discussion Thread, it should be possible to create a JIRA issue prefilled with appropriate information, including a link to the originating PR and discussion item.

thombergs commented 3 years ago

Hey @sfc-gh-sgiesecke,

can you elaborate on that idea a bit? How is it currently possible to create a GitHub issue from a PR review discussion (I didn't find that option). So, if I understand correctly, you would want a button in the GitHub UI that gives you the option to create a Jira ticket?

sfc-gh-sgiesecke commented 3 years ago

You can even see it on this discussion as well. It's the same for a PR review discussion. I am not sure what information goes into the new issue. For JIRA, this must probably be configured with more details, as JIRA has many more fields that might need to be prefilled than GitHub issues.

Screenshot 2021-05-21 at 09 36 27 Screenshot 2021-05-21 at 09 37 01
rachellerathbone commented 1 year ago

Hey @sfc-gh-sgiesecke. Can I get some more clarification around what you're hoping for here? Why specifically from a PR review? I ask this because when our team reviews one another's PRs, we're usually assessing the code that has been written and trying to close out an issue that is already attached to that work. It's hard for me to imagine a scenario where a reviewer would leave a review and then, at some point in the discussion thread, decide a new issue should be created.

sfc-gh-sgiesecke commented 1 year ago

Can I get some more clarification around what you're hoping for here?

Well, to start with I expect the same functionality that exists for creating GitHub issues to be available to create Jira issues.

I ask this because when our team reviews one another's PRs, we're usually assessing the code that has been written and trying to close out an issue that is already attached to that work. It's hard for me to imagine a scenario where a reviewer would leave a review and then, at some point in the discussion thread, decide a new issue should be created.

There are surely different workflows. I am not sure I understand what you're saying here. In my current and also all past projects, it was very typically that there are discussion/action items encountered that are considered worthwhile addressing but shouldn't block the PR at hand. Either a reviewer or an author might decide to move this into an issue in the issue tracker.

As mentioned above, this functionality/integration exists for GitHub issues, and it would be good to be at par at that to support the same workflows.

christian-steinmeyer commented 1 year ago

I second this. When working with a "non-perfect" codebase, it happens frequently, that a reviewer sees something that needs improvement, that doesn't have anything to do directly with the PR at hand and like @sfc-gh-sgiesecke said above, shouldn't block the PR. Github saw this and offered this option to create issues from comments. There also exists https://github.com/atlassian/github-for-jira/issues/723, which asks for something similar and includes a proposal of what that might look like.

DanFCo commented 1 year ago

Came here when looking for a solution to this exact feature. It's available in Bitbucket and would love it for GitHub.

bdun commented 3 months ago

This would be great to have. We use a mix of BB, gitlab and github for client projects, and this would be another good reason to go with github / Jira combo for future projects if supported.

Just for clarification @rachellerathbone when working on projects we often have minor clean up tasks that are needed to be done be can't block the PR merge and pending releases needed. Some of this minor cleanup work might get done right away but often it requires its own validation plan and isn't related to the original updates which is why we often create new lower priority tickets in PRs.

nivivive commented 1 month ago

Would love to have this as well so we don't lose out on additional information and it's quick and efficient use of our time

tim1uphealth commented 4 days ago

Second this! When I identify a TODO and make a Jira ticket I like to highlight the relevant code areas after specifying acceptance criteria, specifying "where to start" to help whoever is implementing, so I'll manually add a link-to-code to the Jira ticket. It would be helpful to be able to do this in the other direction, create the ticket and specify the code location with a comment/markup.