Feature request: Pull request approved

felixveysseyre commented 3 years ago

Hi !

Just as an automation already exists for when a pull-request is declined, it would be nice to trigger action when a pull-request is approved.

Does this feature is already part of your roadmap ?

Thanks !

rachellerathbone commented 3 years ago

Hi @felixveysseyre. The 3 pull request automations currently include what's seen in the below screenshot:

Does merging the PR support the automation you are after? If not, I can try and point you to the right team to make a feature request. We look after the GitHub for Jira integration whereas you'd need to get in contact with the automations team.

mboudreau commented 3 years ago

Haven't heard back in a month, I'm going to close this one. Please reopen it if we haven't answered your question. Cheers.

felixveysseyre commented 3 years ago

@mboudreau I'm sorry, I missed this notification and apparently I do not have sufficient permission to reopen this issue.

@rachellerathbone These three events do not fit my needs. I would like to trigger and action when the pull-request has been approved, not merged To give you some more context, we do have an automated process which deploys automatically the code of the pull-request. Once the the pull-request has been approved, we manually change (that's the behavior we would like to automate) the status of the related Jira ticket in order to let our QA engineers know about it. From here, they are able to test the related changes and merge (or not) the original pull-request

Let me know if it's sill unclear 🙇‍♂️

mboudreau commented 3 years ago

Alright, reopening the issue. Sound like a good idea for a new event. We'll have to bring it up with the team responsible for jira automation.

iamstej commented 2 years ago

+1

We're looking at integrating this same workflow mentioned by @felixveysseyre and glad we found this!

rileywhite commented 2 years ago

I'd appreciate this, as well.

It would be good to include information, for github integrations at least, about all outstanding reviews in all statuses, e.g. requested, approved, etc. If that doesn't make sense, then just having the number of approvals would be useful.

edelegormley commented 2 years ago

+1 would also appreciate this.

simonyun commented 2 years ago

+1; some folks don't have access to GitHub and all they need to know is whether a PR has been approved yet (vs. still waiting for review). So being able to distinguish this from the Jira issue would be very useful.

drdaemos commented 2 years ago

+1; we need to promote approved PRs to further development stages

jackbentley commented 2 years ago

Surely this can't be that difficult. The info from GitHub is already synced to Jira.

https://github.com/atlassian/github-for-jira/blob/5d0e37c544031319ebf8afdb8c2e23055c461677/src/transforms/pull-request.ts#L118

The info is there to use and is already shown alongside the pull request in the development info window

(ignore the red boxes - just best screenshot I could find)

The development panel already has an implementation for review which Crucible uses: https://support.atlassian.com/jira-software-cloud/docs/view-development-information-for-an-issue/#See-the-status-of-reviews

Why is the review information shown for pull requests not surfaced in the same way?

It also means the JQL development[reviews].all doesn't work as expected

SirSaunders commented 2 years ago

+1

Would help a lot with automating our workflows.

christianfds commented 2 years ago

+1

revitteth commented 2 years ago

This would be awesome!

malenazk commented 2 years ago

+1

grancier commented 2 years ago

+1

jchavjim commented 2 years ago

+1

NicholasMiller commented 2 years ago

+1

yanbrod commented 2 years ago

+1

msde commented 2 years ago

+1, and also should this be linked to https://jira.atlassian.com/browse/JRACLOUD-71798 somehow?

ncapdevi commented 2 years ago

+1 on this

jenswet commented 2 years ago

+1

pietmichal commented 2 years ago

+1

jessicaw-iology commented 2 years ago

+1

caique39 commented 2 years ago

+1

coberhauser commented 2 years ago

+1

Murzic commented 2 years ago

+1

SethNuteTwilio commented 2 years ago

+1

danielleos commented 2 years ago

+1

TFarleyAZ commented 2 years ago

+1

bquay commented 2 years ago

+1

johnnyoneill-itv commented 2 years ago

Any more on this one? would be really useful.

jona-termly commented 2 years ago

+1 on getting an update on this issue. Looks like lots of interest.

Ghassen-Ferchichi commented 2 years ago

+1

kry-kylewhittle commented 2 years ago

+1

plcosta commented 2 years ago

+1

jona-termly commented 2 years ago

@mboudreau Any updates here? This would be a huge time saver for us.

shanegiroux commented 2 years ago

Adding a +1 on this, would be a big help

sscovil commented 2 years ago

I was able to solve this problem with a little engineering, and wanted to share what I did in case anyone else is inclined to do so.

Here is an article I wrote, explaining what was done: https://shaunscovil.com/jira-automation-for-github-reviews-5da81ee72af8

bajb commented 1 year ago

+1

rahulv3a commented 1 year ago

+1

samslater commented 1 year ago

+1

This would be nice and also would be nice if we could access who the approver is. We would like to take actions based on which team member approves a PR.