search

atlassian / go-artifactory

Go library for artifactory REST API
Apache License 2.0
23 stars 28 forks source link

Fix nuget config after API change #9

Closed KierranM closed 5 years ago

KierranM commented 5 years ago

JFrog made an undocumented API change in 6.9 that has broken the nuget configuration, the configuration is no longer nested under the nuget object.

I've sent them a ticket requesting that they update the documentation.

KierranM commented 5 years ago

Relates to atlassian/terraform-provider-artifactory#35

dillon-giacoppo commented 5 years ago

Sorry for the delay, I've been travelling :) So from the ticket on the terraform-provider, this is a change in API that was not a major version bump on their side? Let me verify what versions it is compatible with and then we can merge it in

KierranM commented 5 years ago

No worries :). Yeah that's correct, it changed between 6.8.* and 6.9

dillon-giacoppo commented 5 years ago

This will be backwards incompatible. 6.5 is supported until Oct 2019 and 6.8 until Feb 2020 so I don't want to break existing users.

I think the best solution here is to include both in the struct and have the provider implement both. We can then include a deprecation method in terraform. This way older versions can still work and there is a clear path for deprecation.