search

atlassian / gostatsd

An implementation of Etsy's statsd in Go with tags support
MIT License
384 stars 99 forks source link

Breaking change for latest K8s.io API #318

Open MovieStoreGuy opened 4 years ago

MovieStoreGuy commented 4 years ago

I've tried to blindly upgrade all the packages and with k8s.io/client-go v11.0.0+incompatible which appears to be pulled directly with package changes results in this issue:

# k8s.io/client-go/rest
../../go/pkg/mod/k8s.io/client-go@v11.0.0+incompatible/rest/request.go:598:31: not enough arguments in call to watch.NewStreamWatcher
    have (*versioned.Decoder)
    want (watch.Decoder, watch.Reporter)
# k8s.io/client-go/tools/clientcmd/api/v1
../../go/pkg/mod/k8s.io/client-go@v11.0.0+incompatible/tools/clientcmd/api/v1/conversion.go:29:15: scheme.AddConversionFuncs undefined (type *runtime.Scheme has no field or method AddConversionFuncs)
../../go/pkg/mod/k8s.io/client-go@v11.0.0+incompatible/tools/clientcmd/api/v1/conversion.go:31:12: s.DefaultConvert undefined (type conversion.Scope has no field or method DefaultConvert)
../../go/pkg/mod/k8s.io/client-go@v11.0.0+incompatible/tools/clientcmd/api/v1/conversion.go:34:12: s.DefaultConvert undefined (type conversion.Scope has no field or method DefaultConvert)
../../go/pkg/mod/k8s.io/client-go@v11.0.0+incompatible/tools/clientcmd/api/v1/conversion.go:37:12: s.DefaultConvert undefined (type conversion.Scope has no field or method DefaultConvert)
../../go/pkg/mod/k8s.io/client-go@v11.0.0+incompatible/tools/clientcmd/api/v1/conversion.go:40:12: s.DefaultConvert undefined (type conversion.Scope has no field or method DefaultConvert)
../../go/pkg/mod/k8s.io/client-go@v11.0.0+incompatible/tools/clientcmd/api/v1/conversion.go:43:12: s.DefaultConvert undefined (type conversion.Scope has no field or method DefaultConvert)
../../go/pkg/mod/k8s.io/client-go@v11.0.0+incompatible/tools/clientcmd/api/v1/conversion.go:46:12: s.DefaultConvert undefined (type conversion.Scope has no field or method DefaultConvert)
../../go/pkg/mod/k8s.io/client-go@v11.0.0+incompatible/tools/clientcmd/api/v1/conversion.go:49:12: s.DefaultConvert undefined (type conversion.Scope has no field or method DefaultConvert)
../../go/pkg/mod/k8s.io/client-go@v11.0.0+incompatible/tools/clientcmd/api/v1/conversion.go:52:12: s.DefaultConvert undefined (type conversion.Scope has no field or method DefaultConvert)
ash2k commented 4 years ago

https://github.com/kubernetes/client-go/blob/master/INSTALL.md

Also replace can help to pin to the correct version like that:

replace (
    // https://github.com/kubernetes/kubernetes/issues/79384#issuecomment-505627280
    k8s.io/api => k8s.io/api v0.17.6
    k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.17.6
    k8s.io/apimachinery => k8s.io/apimachinery v0.17.6
    k8s.io/apiserver => k8s.io/apiserver v0.17.6
    k8s.io/cli-runtime => k8s.io/cli-runtime v0.17.6
    k8s.io/client-go => k8s.io/client-go v0.17.6
    k8s.io/cloud-provider => k8s.io/cloud-provider v0.17.6
    k8s.io/cluster-bootstrap => k8s.io/cluster-bootstrap v0.17.6
    k8s.io/code-generator => k8s.io/code-generator v0.17.6
    k8s.io/component-base => k8s.io/component-base v0.17.6
    k8s.io/cri-api => k8s.io/cri-api v0.17.6
    k8s.io/csi-translation-lib => k8s.io/csi-translation-lib v0.17.6
    k8s.io/kube-aggregator => k8s.io/kube-aggregator v0.17.6
    k8s.io/kube-controller-manager => k8s.io/kube-controller-manager v0.17.6
    k8s.io/kube-proxy => k8s.io/kube-proxy v0.17.6
    k8s.io/kube-scheduler => k8s.io/kube-scheduler v0.17.6
    k8s.io/kubectl => k8s.io/kubectl v0.17.6
    k8s.io/kubelet => k8s.io/kubelet v0.17.6
    k8s.io/kubernetes => k8s.io/kubernetes v1.17.6 // gitops-engine wants that
    k8s.io/legacy-cloud-providers => k8s.io/legacy-cloud-providers v0.17.6
    k8s.io/metrics => k8s.io/metrics v0.17.6
    k8s.io/sample-apiserver => k8s.io/sample-apiserver v0.17.6
)