feat(package): support for scoped public packages

atlassian / lerna-semantic-release

📦:🛠✨💥 – fully automated package publishing

683 stars 42 forks source link

Closed soneymathew closed 7 years ago

soneymathew commented 7 years ago

fix approach for #54

jpnelson commented 7 years ago

I refactored it bit to move the code into the io/ package, LGTM otherwise

bradleyayers commented 7 years ago

A couple of thoughts:

Why should config:access only be available to scoped packages (as opposed to any package)?
Should should the value of config:access only be allowed to be public, rather than all the supported values? Or even just pass it through directly to the npm publish command?
Can setting npm publish options be done by other means, e.g. npmrc? It would be nice to avoid needing to encode support for each npm publish parameter into this library.