search

atlassian / lerna-semantic-release

📦:🛠✨💥 – fully automated package publishing
https://www.npmjs.com/package/lerna-semantic-release
679 stars 42 forks source link

lerna@3.0.0 support #93

Open lorenzomigliorero opened 5 years ago

lorenzomigliorero commented 5 years ago

Is there any intention to support lerna@3.0.0? Currently, when launch lerna-semantic-release pre i obtain this error:

Error: Cannot find module 'lerna/lib/Repository'

renanbronchart commented 5 years ago

I have the same problem, Do you have any roadmap on this subject?

Thanks a lot.

lukebatchelor commented 5 years ago

It should be as simple as bumping cz-lerna-changelog in here, and also the Lerna dep to a non--prerelease.

I'm not able to test that ATM, but if anyone is able to take a look, I'm happy to test and merge it

silouanwright commented 5 years ago

@lukebatchelor that unfortunately wouldn't be enough, upon testing. The lerna/lib/Repository error that was cited, is coming from the lerna-semantic-release-io package in the monorepo.

I'm attempting to try to fix but I'm not "100%" sure I'll be able to. I'll give it a shot though.

silouanwright commented 5 years ago

@lukebatchelor I got as far as I could I think. My PR is referenced above. Essentially, updating those 2 things you mentioned wasn't enough.

https://github.com/atlassian/cz-lerna-changelog/pull/17/files

There were some changes I found in this PR, that probably need to make it's way here as well. So I made updates, ran tests, tried to fix things further. Could definitely use some help from anyone to push this past the finish line.

CowDotDev commented 4 years ago

Just bumping to see what the status of this is... I may just end up using @reywright's fork to see if we can't get a working version. Though, this should absolutely be something fixed here.

CowDotDev commented 4 years ago

I created a fork with the changes I had to make to get Lerna 3.x support, I also fixed the broken tests. https://github.com/atlassian/lerna-semantic-release/pull/97

Shout out to @reywright for starting the investigation :) had a huge head start thanks to you.