atlassian / nucleus

A configurable and versatile update server for all your Electron apps
Other
394 stars 91 forks source link

Be resilient to file store errors #36

Open MarshallOfSound opened 6 years ago

MarshallOfSound commented 6 years ago

Currently if an unhandled error occurs while transferring files from a TemporaryFile to a released File the operation is aborted but not cleaned up. This means the temporary file remains in the files store but the database entry has been removed.

b-zurg commented 4 years ago

I recently came across an issue like this. This is an important improvement to the platform I think because if something does go wrong in a production release then it can break releasing from then on - unless you manually go into the database - as then, at least with the bug I'm facing, the release file generation is completely broken.