search

atlassian / nucleus

A configurable and versatile update server for all your Electron apps
Other
397 stars 92 forks source link

fix(core-platform): fix file length computation #66

Closed leofidus closed 6 years ago

leofidus commented 6 years ago

If uploading a Windows release with a .nuget file, handleWindowsUpload tries to get the file sizes of all released files. Those sizes are fetched from the index files, but the index files for the current release are only uploaded after handleWindowsUpload is called. Switching the order around seems to do the trick.

It also seems like setting NO_NUCLEUS_INDEX isn't really an option if you want to release windows files.

MarshallOfSound commented 6 years ago

@leofidus If you rebase on latest master the CI should be green 👍 It wasn't set up to handle PRs from forks

leofidus commented 6 years ago

I pushed a rebased version, but it doesn't look like there is a CI report.

MarshallOfSound commented 6 years ago

Hm, I have it set up to build them 🤔 I just toggled the option off and on in Circle CI 😆 if you force push up the exact same commit it should work now 👍