Closed patorjk closed 1 month ago
Thanks!! I think we should update the peer deps to include react18 😊
@alexreardon any estimate when this can be updated, within a week, month, year?
Hours. It might even already be out 😇
✨Good news: I made this change two days ago
😠Bad news: There appears to be an issue with our npm
release pipeline and I can see the new version has not been released yet.
I am following this up now
Yep @alexreardon was just about to mention that 😇 amazing, cheers!
Seems not updated till now.
Yeah some packages seem to be updated, some (eg. tokens, motion or flags, also ds-lib) not (hopefully just yet) 😿 @alexreardon any news?
Good news: everything should be good on npm
now
"peerDependencies": {
"react": "^16.8.0 || ^17.0.0 || ^18.0.0"
},
Please let me know if you are still running into any issues
Great news @alexreardon thanks!
Btw may be not in scope of this package, but any chance to get some other @atlaskit packages up-to-date? Currently getting same react errors on:
And potentially some more
I was checking out some of the optional packages that were suggested and got an error when I tried to install
@atlaskit/pragmatic-drag-and-drop-react-accessibility
, as it had React version ^16.8.0 as a peer dependency. This seems like it may be an error, though I noticed most of codesandbox examples are using React 16. Are newer versions of React supported?Edit: It seemed to work fine in React 18. Also, I noticed the same peer dependency issue in several other packages (ex: @atlaskit/tokens).