atlassian / pragmatic-drag-and-drop

Fast drag and drop for any experience on any tech stack
https://atlassian.design/components/pragmatic-drag-and-drop
Other
7.86k stars 160 forks source link

Can't detect drag from external inside `textarea` #51

Closed hellovietduc closed 1 month ago

hellovietduc commented 1 month ago

I came across this issue where if I drag a file to the webpage, the drop target events fire normally until I drag over a textarea inside that drop target. Is this a platform issue or is there something else I should do to make this work?

alexreardon commented 1 month ago

Could you please create a codesandbox and I'll take a look

hellovietduc commented 1 month ago

@alexreardon Here it is: https://codesandbox.io/p/sandbox/optimistic-colden-xhfl4j

As soon as I drag over the textarea, the console log stops printing.

alexreardon commented 1 month ago

I am looking into this now

alexreardon commented 1 month ago

🐛 Bad news: It looks like you stumbled into a bug with our 'exiting window' logic detection. 🎉 Good news: This was fixed in 1.1.7 - so your example starts working if you update your version from 1.1.3 to 1.1.7

It turns out our old check was logically correct, but it ran into a Chrome bug. Our new check does not hit into the bug 🎉

hellovietduc commented 1 month ago

@alexreardon Thank you very much. Is there a public changelog where I can see what's new in each update?

alexreardon commented 1 month ago

https://atlassian.design/components/pragmatic-drag-and-drop/core-package/changelog/changelog

However, we do hope to publish our releases under the Github releases tab too

cc @ReDrUm