search

atlassian / react-beautiful-dnd

Beautiful and accessible drag and drop for lists with React
https://react-beautiful-dnd.netlify.app
Other
33.15k stars 2.53k forks source link

[Virtualized] [Android] Drag & drop does NOT work on Android device #1679

Open neooleg opened 4 years ago

neooleg commented 4 years ago

Expected behavior

D&D should start and finished correctly

Actual behavior

Item doesn't start drag -- it mostly scrolls

Steps to reproduce

  1. Open the board example for virtualized on Android device in Chrome
  2. Scroll vertically a bit
  3. Try to drag & drop

What version of React are you using?

React version: 16.12.0

What version of react-beautiful-dnd are you running?

react-beautiful-dnd version: 12.2.0

What browser are you using?

Demo

Scroll then drag

Investigation

dsbrlt2002 commented 4 years ago

Implementation with react-window has the same issue in Google Chrome 79 on Android 5

neooleg commented 4 years ago

@alexreardon few architecture questions here, could you please clarify:

[Architectural/Conceptual] Do NOT remove draggable element, but hide it (as it was done in https://github.com/clauderic/react-sortable-hoc).

  1. Is this fit the philosophy of the rbd architecture?
  1. Would you accept PR with "if (isiOS) {}"
alexreardon commented 4 years ago

I’ll take a look at this soon

neooleg commented 4 years ago

@alexreardon did you have a chance to look? ☺️

There is a fix been done using this approach:

Would you accept PR with "if (isiOS) {}"

Do you need a PR for this? Would you accept?

alexreardon commented 4 years ago

If we need to do an isIOS, then that is what we need to do! PR would be great

neooleg commented 4 years ago

@alexreardon could you please check the PR https://github.com/atlassian/react-beautiful-dnd/pull/1749

lovelle-cardoso commented 4 years ago

I'm experiencing this issue too. Any update on this @alexreardon ?