search

atlassian / react-sweet-state

Shared state management solution for React
https://atlassian.github.io/react-sweet-state/
MIT License
871 stars 55 forks source link

add onUnmount hook to container #75

Closed jackbrown closed 4 years ago

codecov-io commented 4 years ago

Codecov Report

Merging #75 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   98.81%   98.82%           
=======================================
  Files          16       16           
  Lines         254      256    +2     
  Branches       40       40           
=======================================
+ Hits          251      253    +2     
  Misses          3        3
Impacted Files Coverage Δ
src/components/container.js 100.00% <100.00%> (ø)
src/store/bind-actions.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb45f29...bc77530. Read the comment docs.

albertogasparin commented 4 years ago

Hey @jackbrown, I've tweaked the PR to change the name (calling it onCleanup so it is a bit less bound to React component lifecycle, same term that hooks use)

albertogasparin commented 4 years ago

This also addresses #74