search

atlassian / smith

Smith is a Kubernetes workflow engine / resource manager
Apache License 2.0
285 stars 24 forks source link

Added deployment checksum annotation to pod template for envFrom updates #357

Closed ychen-atlassian closed 5 years ago

ychen-atlassian commented 5 years ago

I am not sure if bumping the annotation will cause the pod to be reprocessed. I am going to test smith in playground on monday.

nilebox commented 5 years ago

I am not sure if bumping the annotation will cause the pod to be reprocessed.

Yes, it should. I saw comments from SIG Architecture recommending this approach in related GitHub issues. Also see https://github.com/helm/helm/blob/master/docs/charts_tips_and_tricks.md#user-content-automatically-roll-deployments-when-configmaps-or-secrets-change

nilebox commented 5 years ago

@ash2k @ychen-atlassian I think we can actually replace serviceInstance.Spec.UpdateRequests++ with setting annotation with hash on ServiceInstance to make it more consistent with what we do in Deployment. Probably not in this PR though.

ychen-atlassian commented 5 years ago

@ash2k @ychen-atlassian I think we can actually replace serviceInstance.Spec.UpdateRequests++ with setting annotation with hash on ServiceInstance to make it more consistent with what we do in Deployment. Probably not in this PR though.

I think we're already setting a hash with annotation on ServiceInstance 🤔. Maybe service catalog behaves differently with annotations?