atlassian / smith

Smith is a Kubernetes workflow engine / resource manager
Apache License 2.0
285 stars 24 forks source link

Reduce errors from external ServiceInstance failures #370

Closed ychen-atlassian closed 5 years ago

ychen-atlassian commented 5 years ago

This follows on changes from my previous attempts to reduce errors.

  1. Ready Checker should not be returning both the object status and the error, because we already capture whether or not the error is a "user error". Errors just get shoved into the Result object
  2. This means we don't need to deal with weird error special case, and I've bumped down the logging in specific cases
  3. Also copy all the messages and stuff
  4. Also reduce log to Debug for many other lines