So the problem is, this only handled the Invalid reason. Looking at the logs, we actually get far more user errors than we do internal errors (almost no internal errors). Some examples are:
500s from Admission Webhooks with no reason (StatusReasonUnknown)
401s from Admission Webhooks
Timeouts and/or Conflicts (which are currently classified as internal errors!)
This PR fixes this by listing a bunch of errors which should never happen and treats everything else an an external error. It also changes the plugin interface to remove the last traces of errors we are getting.
So the problem is, this only handled the
Invalidreason. Looking at the logs, we actually get far more user errors than we do internal errors (almost no internal errors). Some examples are:This PR fixes this by listing a bunch of errors which should never happen and treats everything else an an external error. It also changes the plugin interface to remove the last traces of errors we are getting.