Access Token support in terraform-provider - Githubissues

atlassian / terraform-provider-artifactory

Terraform provider to manage Artifactory

Apache License 2.0

89 stars 42 forks source link

Access Token support in terraform-provider #67

Open lexual opened 4 years ago

lexual commented 4 years ago

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The golang library go-artifactory looks like it now has accessToken support.

It would be good to have this included in the terraform provider.

If we did implement this, what is the best way to support the output of sensitive data such as an access token?

Are there any plans to support AccessToken generation?

New or Affected Resource(s)

artifactory_XXXXX

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

References

0000

stephanebruckert commented 4 years ago

I would personally be looking to revoke my users tokens via TF.

The golang library go-artifactory looks like it now has accessToken support.

Can you please share a link as I'm not sure you are talking about the same thing?

HMHShawfield commented 4 years ago

I would like to create Access Tokens for artifactory and store them directly into vault.

lindhe commented 3 years ago

@stephanebruckert I guess he is referring to the CreateToken function, which seems to simply use the JFrog REST API.

https://github.com/atlassian/go-artifactory/blob/9b64e51b63cc00a665190cdd5460dd41cb681dd0/artifactory/v1/security.go#L904-L918

donovanmuller commented 3 years ago

I have added Access Token support here: https://github.com/jfrog/terraform-provider-artifactory/pull/4. I could raise a PR here too if applicable. However, it feels like JFrog are going to be maintaining their own fork in future?