search

atlefren / storymap

A jQuery-plugin to create a map that follows your text.
atlefren.github.io/storymap/
MIT License
100 stars 25 forks source link

Demo only in HTTP #5

Open valerio-bozzolan opened 2 years ago

valerio-bozzolan commented 2 years ago

Hi all! I've noticed that the demo does not support HTTPs:

Here how I see it:

Screenshot_2022_02_14_125718

Are you aware of that? :)

Thank you so much for your work. I've discovered it from this list:

https://leafletjs.com/plugins.html

atlefren commented 2 years ago

Hi, thanks for noticing!

To be honest I haven't been looking at this code for several years. but a quick glance at the gh-pages branch (https://github.com/atlefren/storymap/blob/gh-pages/index.html) tells me that the problem probably is that I reference 

<script src="http://cdnjs.cloudflare.com/ajax/libs/underscore.js/1.6.0/underscore-min.js"></script>
<script src="http://cdn.leafletjs.com/leaflet-0.7.2/leaflet.js"></script>

Which won't be loaded on https.

I am not aware of any CDNs hosting leaflet on https, but If you want to investigate this PRs are welcome!

valerio-bozzolan commented 2 years ago

Awwwwww yeah I know this answer! Here it is my friend:

https://unpkg.com/leaflet@0.7.2/dist/leaflet.js

https://unpkg.com/leaflet@0.7.2/dist/leaflet.css

I've stealed it somewhere from the Leaflet documentation.