search

atlosdotorg / atlos

The collaborative workspace for visual verification
https://atlos.org
GNU General Public License v3.0
67 stars 7 forks source link

[staging] Users shouldn't be able to post a change explanation without a change #1014

Closed noah-schechter closed 4 months ago

noah-schechter commented 4 months ago

Note that this is a regression.

Repro

  1. Open an unset attribute's update window.
  2. Write an explanation but don't edit the attribute.
  3. Publish the update.

Current You'll see the change explanation without an accompanying change in the feed.

Expected You shouldn't be able to post a change explanation at all; clicking the Publish button should trigger an error message.

milesmcc commented 4 months ago

So I actually think that this might not be a regression, and rather a long-standing issue with single-select attributes; see the most recent update on https://platform.atlos.org/incidents/YYIYA8.

The issue is that you go from the value being unset, to the value being set (to null); these from Atlos' perspective are different, which explains why there is no error.

In any case, not the expected behavior, so will fix...