search

atlosdotorg / atlos

The collaborative workspace for visual verification
https://atlos.org
GNU General Public License v3.0
59 stars 7 forks source link

Clicking on source material on table view should open the source material's artifacts modal, not source link #924

Open noah-schechter opened 3 months ago

noah-schechter commented 3 months ago

Current Clicking on source material archived from an external site opens that external site. On its own, this behavior is acceptable, though not ideal because the artifacts modal preserves content that may have been taken down from its original source.

However, this creates inconsistent expectations for manually-uploaded source material. Right now, clicking on the globe icon that is displayed for manually-uploaded source material leads to two errors:

Proposed Instead of opening the source link, clicking on source material in table view should open the material's artifacts modal, because this behavior applied to both manually-uploaded and automatically-archived material.

Even if we don't change the behavior, we should fix 1) the logic error and 2) the pop-up message to reflect that they're not opening the source media in a new tab, they're opening the source material's source link.

noah-schechter commented 3 months ago

Would this change involve moving the artifacts modal system out of the incidents page and into a component in the same way the attribute update modal system is contained in edit_attribute in components.ex? Trying to get a handle on this.

noah-schechter commented 3 months ago

This is functional now but I'd like to propose a change in behavior. Right now, all attribute modals open directly in table view, but the source material modals open on the incident page. This behavior feels inconsistent and risks being confusing.

Also, the current interaction is quite slow. I have a feeling this is in part because we're loading (arguably unnecessarily) the entire incident page first. I know this expands the scope of development work on this feature, but I think we should make all modals, including source material modals, display directly in table view to improve performance and maintain consistent behavior.