search

atlowChemi / vite-svg-2-webfont

A vite plugin which generates a webfont out of svg icons
https://www.npmjs.com/package/vite-svg-2-webfont
MIT License
24 stars 8 forks source link

Upgrade to Vite 5 #14

Closed Juneezee closed 5 months ago

Juneezee commented 5 months ago

Closes https://github.com/atlowChemi/vite-svg-2-webfont/issues/13.

We also need to update Vitest to the latest version (1.2.2), otherwise we will get the following error when running the test.

 FAIL  src/optionParser.test.ts > optionParser > parseOptions > sets descent only if defined in options
Error: The specified file globs did not resolve any files in the context.
 ❯ parseFiles src/optionParser.ts:150:15
    148|     const resolvedFiles = files.flatMap(fileGlob => sync(fileGlob, { cwd: context })).map(file => `${context}/${file}`);
    149|     if (!resolvedFiles.length) {
    150|         throw new NoIconsAvailableError('The specified file globs did not resolve any files in the context.');
       |               ^
    151|     }
    152|     return resolvedFiles;

/cc @atlowChemi for review

atlowChemi commented 5 months ago

Overall LGTM, thanks for putting in the time & effort! 🙂

Juneezee commented 5 months ago

Hi @atlowChemi, if this PR looks good to you, maybe we can consider merging it and publish a new version? If there are any specific changes or adjustments you would like me to make, please feel free to let me know. I am more than willing to address any feedback you might have.

Thanks :smiley: !

Juneezee commented 5 months ago

@atlowChemi Friendly ping

atlowChemi commented 5 months ago

Hey @Juneezee sorry for the delay, I have been out for a few days 🙏🏽