Closed Ndevu12 closed 6 months ago
@Ndevu12 This is not a proper PR Title , please rename it
@faid-terence renamed
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/services/couponServices/deleteCoupon.ts | 12 | 14 | 85.71% | ||
src/services/couponServices/readCoupon.ts | 12 | 14 | 85.71% | ||
src/services/couponServices/accessAllCoupon.ts | 14 | 20 | 70.0% | ||
src/services/couponServices/createCouponService.ts | 33 | 40 | 82.5% | ||
src/services/couponServices/updateService.ts | 27 | 41 | 65.85% | ||
<!-- | Total: | 154 | 185 | 83.24% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/startups/dbConnection.ts | 1 | 87.5% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 9220370301: | -0.4% |
Covered Lines: | 1403 |
Relevant Lines: | 1667 |
@Ndevu12 Why did you delete these tests ??
@Ndevu12 Please get all tests back , you deleted them !!!
@faid-terence Sorry for this mistake. I can't say that I didn't do it by intention. The reason for the deletion of these tests is that I was running out of time and I had been fixing the errors they had around 30 minutes. so, because I had an exam at 3:00PM. I had to do quick things so, that I can attend the exam and all others who depend on this PR can progress on their projects. If needed, I can work the tests. Am ready. Also I have managed to write API endpoints documentation
@Ndevu12 Understood but never do that again , it's selfish removing other people's work to keep yours Please work together as a team !
@Ndevu12 Understood but never do that again , it's selfish removing other people's work to keep yours Please work together as a team !
@Ndevu12 Please get all tests back , you deleted them !!!
@faid-terence Now, All tests are added back!
PR Approved @Ndevu12 !
@faid-terence thanks for the assistance and awareness!
Description
This PR introduces the discount coupon feature, allowing vendors to create, manage, and apply discount coupons to customer orders. Key changes include database schema updates, new API endpoints, and comprehensive testing.
Changes Made
Database Design
API Endpoints
Testing
Documentation