search

atmdrops / pydropsonde

0 stars 6 forks source link

Change default QC behaviour? #66

Open Geet-George opened 6 days ago

Geet-George commented 6 days ago

Currently, the QC filtering (filter_qc_flags) does not remove any sondes. This commit is the culprit! The default behaviour was changed to accommodate (AC)3 strategy, where they didn't want to filter any sonde, but add quality flags instead.

I would recommend going for the JOANNE strategy, i.e. only keeping GOOD (implementation remaining) sondes post-L1. If any other sondes are needed, then the user can dig them out of L1, but as data providers we can keep the quality and definitions consistent if we have only good sondes.

So, if we agree on this recommendation, then we should basically undo the aforementioned commit and it should work okay. :)

hgloeckner commented 5 days ago

I think it's okay to have that as the default, but I added a description of the dangers to the docs with PR #67 and also added the qc to the example config. Hopefully that's enough?

Geet-George commented 2 days ago

Yep, I think that should be enough. Thanks Helene.