search

atmelcorp / atmel-software-package

Atmel Software Package
Other
108 stars 76 forks source link

Fix SAMA5D3 disable_ddr in common.gdb #113

Closed iKlask closed 2 years ago

iKlask commented 2 years ago

Fixed GDB debug script for SAMA5D3. Incorrect peripheral ID disabled for MPDDRC controller.

Previous: 0xFFFFFC14 = (1 << 16) Sets the disable Peripheral ID for UART0 in PMC_PCDR0

Change: 0xFFFFFD04 = (1 << 17) Sets the disable Peripheral ID for MPDDR Controller in PMC_PCDR1

See Table 8-1. Peripheral Identifiers and register definitions for 26.17.5 PMC Peripheral Clock Disable Register 0 and 26.17.24 PMC Peripheral Clock Disable Register 1

TonyHan11 commented 2 years ago

Thank you for your patch. Would you like to update the commit message to "target/sama5d3/toolchain/gnu: fix disable_ddr in common.gdb" and add "Signed-off-by" part in the commit? Thanks.

iKlask commented 2 years ago

Okay I amended the commit message

TonyHan11 commented 2 years ago

I meant to add your signature, not mine:)

iKlask commented 2 years ago

ah, my bad. fixed