search

atmelcorp / atmel-software-package

Atmel Software Package
Other
106 stars 79 forks source link

Add logical unit (lun) count in the NAND device size calculation #89

Closed hilt0n closed 4 years ago

hilt0n commented 4 years ago

Add the possibility to manage 1GB NAND devices (with 2 logical units) with SAM-BA

TonyHan11 commented 4 years ago

Thanks for your pull request and is there any cases that different LUNs have different sizes? If the answer is yes might the updated expression be incorrect. PS: would you like to update the message to "drivers/nvm/nand: add logical unit (lun) count in the NAND device size calculation" and add "Signed-off-by" to it?

hilt0n commented 4 years ago

From what I know regarding NAND, the logical unit have the same size configuration each. The ONFI parameters gives sector/page size for the lun in a absolute manner and there is a parameter for the number of lun. Sure, I can modify the message, do I have to ammend the previous commit and create a new merge request or there is a simpler way to do that ?

TonyHan11 commented 4 years ago

OK. You needn't create a new request, just to amend the previous commit and rebase it on the latest master branch then push it to github again is OK.