search

atmh / pe

0 stars 0 forks source link

Case sensitivity for a person's name #5

Open atmh opened 2 years ago

atmh commented 2 years ago

Steps to reproduce:

  1. Execute add n/Damith p/99998888 e/damith@damith.com a/Blk 123 i/package 1
  2. Execute add n/damith p/99998888 e/damith@damith.com a/Blk 123 i/package 1

Expected: Error message "This client already exists in the address book"

Actual: Command executed successfully.

Reason: In reality "Damith" and "damith" is highly likely to be the same person. The address book should recognize that they are similar and ideally throw an error message, or give a warning in such near match cases.

image.png

From CS2103T website:

image.png

nus-pe-script commented 2 years ago

Team's Response

We want to give the user more flexibility, and so our feature does not enforce duplication detection. Hence, we don't think this is a bug.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The dev team claims that they do NOT enforce duplicate detection. However, there is clearly some form of duplicate detection. Steps to reproduce:

  1. Execute "add n/Damith p/99998888 e/damith@damith.com a/Blk 123 i/package 1" twice.

image.png


Evidently, there IS duplicate detection. To reiterate my point, in reality "Damith" and "damith" is highly likely to be the same person. However, the app treats them as different individuals. The limitations of this feature is not made clear to the users. It was never stated how duplicate detection works, and this is a flaw in itself.

This bug report follow closely to the Bugs related to duplicate detection of the CS2103T website. Combined with the fact that how duplicate detection works is never mentioned, this should be at minimum a severity.low bug or higher.

image.png