search

atmoner / Bittytorrent

Bittytorrent – Ultimate Php Bittorrent CMS
GNU General Public License v3.0
17 stars 12 forks source link

Cleanups/chmod gitignore #2

Closed Quix0r closed 7 years ago

Quix0r commented 7 years ago

This PR ignores all torrent files as they should never be committed and also libs/db.php as it contains sensitive infomations. This also fixes CHMOD. Only scripts that should be run from shell must have execute flag set, all others not. The server does not execute PHP scripts, it only reads them.

Quix0r commented 7 years ago

The 2nd commit removes my added error_reporting(0); commands again as your script issues many E_NOTICE. Please fix them all: error_reporting(E_ALL | E_STRICT); is generally only for development environments 0 for productive servers.

Quix0r commented 7 years ago

And yeah, my changes remove external references as it is generally not a good idea to have them around.

atmoner commented 7 years ago

@Quix0r Thank you for your work! I will test all this when I go home and if it works without error I would validate the push

atmoner commented 7 years ago

@Quix0r I am not against the modification of the check of the install! But the user should be warned to create a db.php file (in install.php). And thanks for the missing javascript file!

Quix0r commented 7 years ago

Okay, then better mention that change in readme file.

Quix0r commented 7 years ago

Should I add it or do you add it?