atmos / camo

:lock: an http proxy to route images through SSL
MIT License
1.8k stars 370 forks source link

original filename not visible in save as-window. #108

Open bartgrefte opened 7 years ago

bartgrefte commented 7 years ago

A couple of months a go, a Dutch forum I regularly visit started using Camo to be able to offer all pictures through https.

Unfortunately, because of this, every picture loaded through Camo cannot be saved using the original filename. The save as-window always shows ic.tweakimg.net.jpg.

Is there an option that can be enabled to show the original filename in the save as-window?

dropwhile commented 7 years ago

A motivated person could add code to check if the request url ends with something that looks like a filename, and set that in a content-disposition: filename= header response.

I created a throwaway test branch in my Go reimplementation of camo, and it seemed to work ok (very minimal testing). link

Something similar could be done for camo itself. Most likely you would need to fork camo and make the change yourself though, as from what I understand (based on issues filed in this repo) camo itself is mostly feature frozen at this point.

Edit: Do note that there are some subtleties surrounding encoding the filename. My linked code example is purposefully naïve just for testing.