Group Chat Support - Githubissues

atmos / hubot-gtalk

GTalk adapter for Hubot

MIT License

14 stars 6 forks source link

Group Chat Support #15

Closed noazark closed 12 years ago

noazark commented 12 years ago

This is a rather naive fix for gtalk group chat. It works fine in both groups and one-on-one chats. There seem to be some quirks that I'm hacking around, I'll smooth these out more once I dig into the XMPP spec some more.

I'd love some feedback.

sapegin commented 12 years ago

Thank you! Is this pull request ready for merge?

noazark commented 12 years ago

Yup! I've been using it non-stop since the pull. The only thing to watch out for, obviously, is it follows all the whitelist rules you've set up in Hubot.

machadogj commented 11 years ago

noazark,

I am trying this with a groupchat and it's not working. It might work with a few tweaks, but only if I:

login in with the user in gmail
launch the hubot with -a gtalk
establish the group chat
take it from there

It displays a message saying: "[username]'s chat client doesn't support group chats." otherwise.

Are you able to start the group chat without doing this?

Thanks!