atmos / warden-github

:lock: warden strategy for github oauth
MIT License
54 stars 41 forks source link

Wrong web endpoint used for enterprise github #32

Closed laurentgo closed 11 years ago

laurentgo commented 11 years ago

For enterprise github instances, if octokit is directly configured instead of using environment variables OCTOKIT_ to specify the web domain and the API domain, warden-github may end up using the wrong domain name for authentication. The cause is that Octokit::Configuration::DEFAULT_WEB_DOMAIN is relying on environment only.