Make avatar_url available through the user object

atmos / warden-github

:lock: warden strategy for github oauth

MIT License

54 stars 41 forks source link

Make avatar_url available through the user object #40

Closed eugeneius closed 10 years ago

eugeneius commented 10 years ago

The gravatar_id attribute has been deprecated in favour of avatar_url: https://developer.github.com/changes/2014-09-05-removing-gravatar-id/

Removing gravatar_id entirely would break clients, but avatar_url should at least be available.

fphilipe commented 10 years ago

Out of curiosity, was this introduced with the GH hosted avatars?

eugeneius commented 10 years ago

I'm just going by the information in the blog post, but it looks like that's the reason alright:

Users have been able to upload avatars directly to GitHub for a while now. [...] As a result, the gravatar_id attribute no longer identifies a GitHub user’s canonical avatar. Instead, API consumers should use the avatar_url to fetch a user’s avatar.

atmos commented 10 years ago

Thanks.