Suggested edits from Hollister review for JOSS

jhollist commented 6 years ago

[x] R Dependency to 3.3.0
[x] Check on Authorship - Different author list on paper vs. software.
[x] Fix example on emis_opt
[x] Check example on wrf_plot to make sure the warning is not a problem
[x] Add a separate section to README for installation instructions. A good example is https://github.com/ropensci/lawn
[x] Add tests. Should have coverage for at least the main functions.
[x] Add details on how to contribute in a CONTRIBUTING.md
[x] Provide better justification for the package. In particular, provide more detail on why an R package is needed on top of the already available lower level implementation in Fortran and C.
[x] Add DOIs to references.
[x] Review PR #21 for suggested edits
[ ] As a future enhancement, add a vignette showing typical use case

ibarraespinosa commented 6 years ago

Dear @jhollist thank you for your comprehensive review. Some fixes are were included in this commit. We will fix the other items of this issue in coming days. Thanks

ibarraespinosa commented 6 years ago

Dear @jhollist and @leeper, with the our last commit we added coverage of 89%. It was not easy but I resolved to add a file in inst/extdata for comparisons. We also updated the paper.

Please, let us know what do you think.

Best, Sergio

leeper commented 6 years ago

Great! @jhollist Let me know what you think over on the review issue: https://github.com/openjournals/joss-reviews/issues/607

jhollist commented 6 years ago

See comments on openjournals/joss-reviews#607, but the gist is 👍

ibarraespinosa commented 6 years ago

Thanks @leeper and @jhollist. https://github.com/openjournals/joss-reviews/issues/607

atmoschem / eixport

Suggested edits from Hollister review for JOSS #22