Closed ibarraespinosa closed 1 year ago
Hi @ibarraespinosa , sup
I will check some of the changes (I believe all changes were documented in news.md), do you think the wrf_get shoud call wrf_raster for as_raster = T? this probably solve pocible incompatibilities and make all the process better but dont have 'back-compatibility', another option is to put a option to use the old code for reasons of back-compabibility and reproduce with the previous code.
I will try to include all WRF projections in wrf_raster for the this new CRAN version.
There is other important change? do we need more tests for the package?
Thanks
I will keep as_raster for back-compability reasons (taking out would break lots of my code)
What about a meeting to talk about the projections?
nothing more important at the moment.
Have a nice day
On Tue, Apr 12, 2022 at 8:48 AM Daniel Schuch @.***> wrote:
Hi @ibarraespinosa https://github.com/ibarraespinosa , sup
I will check some of the changes (I believe all changes were documented in news.md), do you think the wrf_get shoud call wrf_raster for as_raster = T? this probably solve pocible incompatibilities and make all the process better but dont have 'back-compatibility', another option is to put a option to use the old code for reasons of back-compabibility and reproduce with the previous code.
I will try to include all WRF projections in wrf_raster for the this new CRAN version.
There is other important change? do we need more tests for the package?
Thanks
— Reply to this email directly, view it on GitHub https://github.com/atmoschem/eixport/issues/73#issuecomment-1096829479, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGRM74HBDHGNDEOG5B5VI63VEWENNANCNFSM5THQYVUA . You are receiving this because you were mentioned.Message ID: @.***>
Hello
Of course, we can meet 1 hour on the next days to talk about these stuff
I'm sending a Doodle pool
Thanks
Hello @ibarraespinosa
Everything is set! the 4 WRF projections are included in wrf_raster and wrf_get(as_raster = TRUE) uses the updated wrf_raster. I fix some warnings that make the github automatic tests to fail and the new version is ready to be submitted to CRAN.
Thanks, Daniel
perfect. I will fix the CRAN problem as well. Have a nice day
On Thu, Apr 14, 2022 at 1:13 PM Daniel Schuch @.***> wrote:
Hello @ibarraespinosa https://github.com/ibarraespinosa
Everything is set! the 4 WRF projections are included in wrf_raster and wrf_get(as_raster = TRUE) uses the updated wrf_raster. I fix some warnings that make the github automatic tests to fail and the new version is ready to be submitted to CRAN.
Thanks, Daniel
— Reply to this email directly, view it on GitHub https://github.com/atmoschem/eixport/issues/73#issuecomment-1099542227, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGRM74DXBQ5GMIUWPJRLMT3VFBU37ANCNFSM5THQYVUA . You are receiving this because you were mentioned.Message ID: @.***>
PS: The Picture of the raster (projected to latlon) and points using XLONG / XLAT from WRF
Em qui., 14 de abr. de 2022 às 15:14, Sergio Ibarra Espinosa < @.***> escreveu:
perfect. I will fix the CRAN problem as well. Have a nice day
On Thu, Apr 14, 2022 at 1:13 PM Daniel Schuch @.***> wrote:
Hello @ibarraespinosa https://github.com/ibarraespinosa
Everything is set! the 4 WRF projections are included in wrf_raster and wrf_get(as_raster = TRUE) uses the updated wrf_raster. I fix some warnings that make the github automatic tests to fail and the new version is ready to be submitted to CRAN.
Thanks, Daniel
— Reply to this email directly, view it on GitHub <https://github.com/atmoschem/eixport/issues/73#issuecomment-1099542227 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AGRM74DXBQ5GMIUWPJRLMT3VFBU37ANCNFSM5THQYVUA
. You are receiving this because you were mentioned.Message ID: @.***>
— Reply to this email directly, view it on GitHub https://github.com/atmoschem/eixport/issues/73#issuecomment-1099543243, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHZUTPHGNWNFNQIDLNKIZ63VFBVBVANCNFSM5THQYVUA . You are receiving this because you are on a team that was mentioned.Message ID: @.***>
-- Daniel Schuch Meteorologist, D.Sc., Postdoctoral Research Associate at Northeastern University. Linkedin https://www.linkedin.com/in/daniel-schuch-b71295130/ | Lattes http://lattes.cnpq.br/7656605773440811 | Github https://github.com/Schuch666 & atmoschem https://github.com/atmoschem | 1-857-269-8017
hi @atmoschem/developers
I'm planning by the end of April or Mid May submit eixport to CRAN.
Please, comment any changes that you would like to be seen in eixport. Obviously, the idea is not to take out anything that can break currently working scripts.
Have a nice one